Skip to content

Update turbo-native-modules-android.md#4844

Merged
Simek merged 4 commits into
react:mainfrom
ewhite-nvisia:patch-1
Oct 14, 2025
Merged

Update turbo-native-modules-android.md#4844
Simek merged 4 commits into
react:mainfrom
ewhite-nvisia:patch-1

Conversation

@ewhite-nvisia

@ewhite-nvisia ewhite-nvisia commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

clear method missing from java snippet for NativeLocalStorageModule implementation in TurboNativeModule Tutorial

`clear` method missing from java snippet for `NativeLocalStorageModule` implementation
@meta-cla

meta-cla Bot commented Oct 10, 2025

Copy link
Copy Markdown

Hi @TimeAndRelativeDimensionInSpaceCadet!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Oct 10, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 638accb
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/68ee7466169e000008accb67
😎 Deploy Preview https://deploy-preview-4844--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ewhite-nvisia ewhite-nvisia reopened this Oct 10, 2025
@meta-cla

meta-cla Bot commented Oct 10, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Oct 10, 2025
@Simek

Simek commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

Hey @TimeAndRelativeDimensionInSpaceCadet, nice catch! 👍

Can you also update unversioned file located in /docs and backport the change also to older versions?

@ewhite-nvisia

Copy link
Copy Markdown
Contributor Author

@Simek updated! turns out version .80 of the doc already had it, incidentally.

@Simek Simek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the update, let's ship it! 🚀

@Simek Simek merged commit 0db29c1 into react:main Oct 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants