Skip to content

update macos icon to tahoe#4843

Merged
Simek merged 4 commits into
react:mainfrom
fobos531:main
Oct 9, 2025
Merged

update macos icon to tahoe#4843
Simek merged 4 commits into
react:mainfrom
fobos531:main

Conversation

@fobos531

@fobos531 fobos531 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Super minor change, simply updates the macOS icon on the landing page to Tahoe. Used this one: https://x.com/aaronp613/status/1937243831155474872

CleanShot 2025-10-09 at 10 46 20@2x

@meta-cla

meta-cla Bot commented Oct 9, 2025

Copy link
Copy Markdown

Hi @fobos531!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Oct 9, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 8e99490
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/68e7a3e052c4b700080c834f
😎 Deploy Preview https://deploy-preview-4843--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla meta-cla Bot added the CLA Signed label Oct 9, 2025
@meta-cla

meta-cla Bot commented Oct 9, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Simek

Simek commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

Hey @fobos531, nice attention to the details! 👍

One thing before we can merge, looks like the icon now has a baked in white background which causes a visual issue in dark mode:

Screenshot 2025-10-09 113128

Looks like it is due to source image change from PNG to JPG.

@fobos531

fobos531 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

@Simek Thanks for catching it - let me know if the new one works better.

@Simek

Simek commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the update @fobos531, it looks good now! 🙏

There are some bit rough edges around the container, but this also can be seen on currently deployed version prior the change, so we can tackle this separately.

One thing which came to my mind: looks like the image base64 string is significantly larger than before. Did you run any loseless optimizations on the PNG asset before converting it, i.e using ImgOptim app or TinyPng website?

@fobos531

fobos531 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the update @fobos531, it looks good now! 🙏

There are some bit rough edges around the container, but this also can be seen on currently deployed version prior the change, so we can tackle this separately.

One thing which came to my mind: looks like the image base64 string is significantly larger than before. Did you run any loseless optimizations on the PNG asset before converting it, i.e using ImgOptim app or TinyPng website?

@Simek Honestly I couldn't remember what the tools were called 😅 Ran it through TinyPng, its now down to 160 KB. I tried running it multiple times but afterwards it starts developing artifacts and the savings are negligible.

@Simek Simek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's leave it as-is for now, we can look at optimization later in time, thanks! 🚀

@Simek Simek merged commit 756f745 into react:main Oct 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants