update macos icon to tahoe#4843
Conversation
|
Hi @fobos531! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hey @fobos531, nice attention to the details! 👍 One thing before we can merge, looks like the icon now has a baked in white background which causes a visual issue in dark mode:
Looks like it is due to source image change from PNG to JPG. |
|
@Simek Thanks for catching it - let me know if the new one works better. |
|
Thanks for the update @fobos531, it looks good now! 🙏 There are some bit rough edges around the container, but this also can be seen on currently deployed version prior the change, so we can tackle this separately. One thing which came to my mind: looks like the image base64 string is significantly larger than before. Did you run any loseless optimizations on the PNG asset before converting it, i.e using ImgOptim app or TinyPng website? |
@Simek Honestly I couldn't remember what the tools were called 😅 Ran it through TinyPng, its now down to 160 KB. I tried running it multiple times but afterwards it starts developing artifacts and the savings are negligible. |
Simek
left a comment
There was a problem hiding this comment.
Okay, let's leave it as-is for now, we can look at optimization later in time, thanks! 🚀

Super minor change, simply updates the macOS icon on the landing page to Tahoe. Used this one: https://x.com/aaronp613/status/1937243831155474872