Skip to content

Simplify JavaScriptCore opt-out instructions#4825

Merged
Simek merged 3 commits into
react:mainfrom
jvaronenka:patch-1
Oct 2, 2025
Merged

Simplify JavaScriptCore opt-out instructions#4825
Simek merged 3 commits into
react:mainfrom
jvaronenka:patch-1

Conversation

@jvaronenka

Copy link
Copy Markdown
Contributor

Current instructions were no longer correct - just switching the options would make the application crash. Thus, I removed detailed instructions for switching back to JavaScriptCore from Hermes by linking to the other repository, which has correct instructions.

Removed detailed instructions for switching back to JavaScriptCore from Hermes.
@meta-cla

meta-cla Bot commented Sep 30, 2025

Copy link
Copy Markdown

Hi @jvaronenka!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Sep 30, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 3d25e50
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/68dcc7a39232bf00084e44d1
😎 Deploy Preview https://deploy-preview-4825--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread website/versioned_docs/version-0.81/hermes.md Outdated
jvaronenka and others added 2 commits October 1, 2025 09:14
Updated the way the link to community repo appears visually

@Simek Simek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @jvaronenka! 👍

Last thing - can you accept the CLA so we can merge those changes in?

@meta-cla meta-cla Bot added the CLA Signed label Oct 1, 2025
@Simek Simek merged commit 421fde4 into react:main Oct 2, 2025
4 checks passed
@jvaronenka jvaronenka deleted the patch-1 branch October 2, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants