Simplify JavaScriptCore opt-out instructions#4825
Conversation
Removed detailed instructions for switching back to JavaScriptCore from Hermes.
|
Hi @jvaronenka! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Updated the way the link to community repo appears visually
There was a problem hiding this comment.
Thanks for the updates @jvaronenka! 👍
Last thing - can you accept the CLA so we can merge those changes in?
Current instructions were no longer correct - just switching the options would make the application crash. Thus, I removed detailed instructions for switching back to JavaScriptCore from Hermes by linking to the other repository, which has correct instructions.