fix Snacks preview appearance, allow customizing, tweak few examples#4754
Merged
Merged
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cortinico
approved these changes
Aug 28, 2025
Simek
deleted the
@simek/fix-snack-preview-appearance-tweak-examples
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
So far, the Snack embedded element theme was coupled with preview device appearance which in some cases lead to readability problems in dark mode.
Refs:
Should address issues bring up in:
How
Add support for
deviceAppearancequery param, set it by default to'light', but allow customization on case-by-case base.In the process, I have also updated few examples, to make sure that they display and work correctly on mobile previews.
Preview