Skip to content

Add build-types to how-to-contribute-code page #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huntie merged 2 commits into from
Jun 30, 2025
+7 −5
Merged

Add build-types to how-to-contribute-code page #4667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6558efd
add build-types to how-to-contribute-code page
coado Jun 30, 2025
f71bbea
change build-types desc
coado Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions website/contributing/how-to-contribute-code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Now you are set up to run several commands:
- `yarn test-ios` runs the iOS test suite (macOS required).
- `yarn build` builds all configured packages — in general, this command only needs to be run by CI ahead of publishing.
- Packages which require a build are configured in [scripts/build/config.js](https://github.com/facebook/react-native/blob/main/scripts/build/config.js).
- `yarn build-types` generates TypeScript types for the public API and updates the snapshot.

## Testing your Changes

Expand Down Expand Up @@ -70,11 +71,12 @@ Code-level contributions to React Native generally come in the form of [a pull r
3. If you've changed APIs, update the documentation.
4. Ensure the test suite passes, either locally or on CI once you opened a pull request.
5. Make sure your code lints (for example via `yarn lint --fix`).
6. Push the changes to your fork.
7. Create a pull request to the React Native repository.
8. Review and address comments on your pull request.
9. A bot may comment with suggestions. Generally we ask you to resolve these first before a maintainer will review your code.
10. If you haven't already, submit the [Contributor License Agreement ("CLA")](#contributor-license-agreement).
6. Verify if your code modifies the JS public API with `yarn build-types --validate`. If so, regenerate the snapshot using `yarn build-types`.
7. Push the changes to your fork.
8. Create a pull request to the React Native repository.
9. Review and address comments on your pull request.
10. A bot may comment with suggestions. Generally we ask you to resolve these first before a maintainer will review your code.
11. If you haven't already, submit the [Contributor License Agreement ("CLA")](#contributor-license-agreement).

If all goes well, your pull request will be merged. If it is not merged, maintainers will do their best to explain their reasoning.

Expand Down