Skip to content

Reword accessible section in Accessibility guide#4653

Closed
joevilches wants to merge 0 commit into
react:mainfrom
joevilches:main
Closed

Reword accessible section in Accessibility guide#4653
joevilches wants to merge 0 commit into
react:mainfrom
joevilches:main

Conversation

@joevilches

Copy link
Copy Markdown
Contributor

The current description of the accessible prop is misleading and confusing. The current wording implies that this prop mainly "groups its children into a single selectable component", which is a round-about way of saying it can receive focus, I think? I am not really sure what that means.

Regardless, the main point is not hammered home: This prop allows the View to be discoverable by screen readers (and other things).

The example is also a bit misleading, since Text is focusable by default on iOS. It is not wrong, but the example is better for a guide on label co-opting, not basic use of accessible.

Curious how, if at all, I should change this for previous versions.

@joevilches

Copy link
Copy Markdown
Contributor Author

@cortinico For a change like this one where I am just rewording things, should I push this to previous versions of the docs, and if so how many?

@netlify

netlify Bot commented Jun 16, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 0ce5a9f
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/6851d4bda578fc000843bedb
😎 Deploy Preview https://deploy-preview-4653--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joevilches I'd say let's backport this down to 0.78 which is the versions we currently support

Comment thread docs/accessibility.md Outdated
```

In the above example, accessibility focus is only available on the parent view with the `accessible` property, and not individually for 'text one' and 'text two'.
In the above example, accessibility focus is only available on the first child view with the `accessible` property, and not individually for the other views.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and not individually for the other views.

This is confusing as there is only another view, and you saying "other views" is unclear what you're referring to.

@joevilches

Copy link
Copy Markdown
Contributor Author

cc @cortinico I moved this to a new pr #4656. My fork was messed up with a bunch of old commits. I got rid of those and made a new branch for this so its clearer. I also responded to the edits there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants