Add TypeScript type annotations for improved type safety#4511
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Files in theme directory comes from Docusaurus swizzle mechanism and they should not be altered without an explicit functional need, since this complicates the upgrade process.
If you would like to see the improved types in there (since they seem to be present in upstream), you should reswizzle the latest version of components, and apply the React Native website custom changes on top of that, instead of typing things manually:
- https://github.com/facebook/docusaurus/blob/75e5a00a66aae4f0e9dfbca9a4c85977028a37b8/packages/docusaurus-theme-classic/src/theme/EditMetaRow/index.tsx
- https://github.com/facebook/docusaurus/blob/75e5a00a66aae4f0e9dfbca9a4c85977028a37b8/packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/index.tsx#L51
|
cc @Simek |
|
Hey @clicktodev, can you revert changes to the files in We can also split this up into multiple PRs, and focus in this one on changes to our own code. |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
alright i'll avoid docusaurus components for now |
|
done |
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Thanks for the updates! 🚀
3 participants
Introduce TypeScript type annotations across various components to enhance type safety and improve type inference for better developer experience.