Disable AMD

[martnu]

Disable AMD and solve swagger client issues since there is no intention of supporting it:

#3247 (comment)

[Timer]

I've also seen an alternative way to disable AMD: https://github.com/webpack-contrib/imports-loader#disable-amd

Can you please explain the difference between the two?

p.s. thanks for the PR!

[martnu]

@Timer Well, disabling it via module.rules.parser disables the entire AMD-plugin for webpack. (https://github.com/webpack/webpack/blob/ed9691585e5f5e8d8a6c5985465b85f5ea265011/lib/dependencies/AMDPlugin.js#L101)

While doing it via imports-loader sets the define-variable to false which is used to check for AMD in most UMD-modules. See https://github.com/umdjs/umd/blob/master/templates/commonjsStrict.js#L20

[Timer]

I just want to make sure we can still load a UMD module that specifies AMD and it's not broken using this proposed option. Can we add an e2e test for this, please?

[Timer]

Hi @martnu! Could you please tell us why you closed this?

[martnu]

I suggest using another client generation language for swagger, for instance typescript-fetch. This will generate a commonjs-friendly client.

[Timer]

Sure, but we still want to disable AMD for other users!