Fix broken link in router docs - #5579
Closed
yangshun wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Hmm there's also a path problem as mentioned in #5552. Closing this. We should fix the path problem together with this naming problem. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct link should be https://facebook.github.io/create-react-app/docs/deployment#serving-apps-with-client-side-routing.
Frankly, I didn't test this, but it should be a pretty safe change. Highly encourage the project to integration Netlify preview builds for Docusaurus PRs so that maintainers can easily verify the doc changes.