Fix GENERATE_SOURCEMAP env not working for css sourcemap - #5246
Merged
Conversation
Contributor
|
Thanks! For now you can just remove the files safely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
GENERATE_SOURCEMAPenv option not being respected for css sourcemap, by checking its presence before passing sourcemap options toOptimizeCSSAssetsPlugin.It can be simply tested by running
react-scripts buildwith and withoutGENERATE_SOURCEMAP=false, and see if any sourcemaps are being created underbuild/static/css