Skip to content

fix(cli): preserve registry prefixes and select matching templates in one pass #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −44
Open

fix(cli): preserve registry prefixes and select matching templates in one pass #2832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 20 additions & 44 deletions packages/cli/src/tools/npm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,15 @@ export const getNpmRegistryUrl = (() => {
};
})();

function getNpmPackageUrl(packageName: string, version?: string): URL {
const url = new URL(getNpmRegistryUrl());
const packagePath = encodeURIComponent(packageName);
url.pathname = `${url.pathname.replace(/\/?$/, '/')}${packagePath}${
version === undefined ? '' : `/${encodeURIComponent(version)}`
}`;
return url;
}

/**
* Convert an npm tag to a concrete version, for example:
* - next -> 0.75.0-rc.0
Expand All @@ -59,8 +68,7 @@ export async function npmResolveConcreteVersion(
packageName: string,
tagOrVersion: string,
): Promise<string> {
const url = new URL(getNpmRegistryUrl());
url.pathname = `${packageName}/${tagOrVersion}`;
const url = getNpmPackageUrl(packageName, tagOrVersion);
const resp = await fetch(url);
if (
[
Expand All @@ -80,10 +88,6 @@ export async function npmResolveConcreteVersion(

type TimeStampString = string;
type TemplateVersion = string;
type VersionedTemplates = {
[rnVersion: string]: Template[];
};

type NpmTemplateResponse = {
versions: {
// Template version, semver including -rc candidates
Expand All @@ -103,27 +107,11 @@ type NpmTemplateResponse = {
};
};

class Template {
version: string;
reactNativeVersion: string;
published: Date;

constructor(version: string, reactNativeVersion: string, published: string) {
this.version = version;
this.reactNativeVersion = reactNativeVersion;
this.published = new Date(published);
}

get isPreRelease() {
return this.version.includes('-rc');
}
}

export async function getTemplateVersion(
reactNativeVersion: string,
): Promise<TemplateVersion | undefined> {
const json = await fetch(
new URL('@react-native-community/template', getNpmRegistryUrl()),
getNpmPackageUrl('@react-native-community/template'),
).then((resp) => resp.json() as Promise<NpmTemplateResponse>);

// We are abusing which npm metadata is publicly available through the registry. Scripts
Expand All @@ -137,33 +125,21 @@ export async function getTemplateVersion(
// - No: we don't have a version of the template for a version of React Native. There should
// at a minimum be at least one version cut for each MAJOR.MINOR.PATCH since 0.75. Before this
// the template was shipped with React Native
const rnToTemplate: VersionedTemplates = {};
let latestVersion: TemplateVersion | undefined;
let latestPublished = -Infinity;
for (const [templateVersion, pkg] of Object.entries(json.versions)) {
const rnVersion = pkg?.scripts?.reactNativeVersion ?? pkg?.scripts?.version;
if (rnVersion == null || !semver.valid(rnVersion)) {
if (rnVersion !== reactNativeVersion || !semver.valid(rnVersion)) {
// This is a very early version that doesn't have the correct metadata embedded
continue;
}

const template = new Template(
templateVersion,
rnVersion,
json.time[templateVersion],
);

rnToTemplate[rnVersion] = rnToTemplate[rnVersion] ?? [];
rnToTemplate[rnVersion].push(template);
}

// Make sure the last published is the first one in each version of React Native
for (const v in rnToTemplate) {
rnToTemplate[v].sort(
(a, b) => b.published.getTime() - a.published.getTime(),
);
const published = new Date(json.time[templateVersion]).getTime();
if (latestVersion === undefined || published > latestPublished) {
latestVersion = templateVersion;
latestPublished = published;
}
}

if (reactNativeVersion in rnToTemplate) {
return rnToTemplate[reactNativeVersion][0].version;
}
return;
return latestVersion;
}
Loading