perf: add marks dot classname#842
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 13 13
Lines 535 540 +5
Branches 147 150 +3
=======================================
+ Hits 534 539 +5
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Docs and test case please. |
|
Prefer to have <Slider classNames={{ markedDot: 'custom-dot' }} /> |
| <Dot | ||
| prefixCls={prefixCls} | ||
| className={classNames({ | ||
| [`${prefixCls}-marks-dot`]: isMarksDot, |
There was a problem hiding this comment.
[`${prefixCls}-marks-dot`]: isMarksDot,
+markedDot,@MadCcc An additional?
There was a problem hiding this comment.
Yeah, current design do not need a className to style dot with mark. It's better to append customized className to this element.
There was a problem hiding this comment.
OK, I'll write it down when I have time.
I need to do something special with the dot for marks, but I don't have a class name for marks, so I think it's worth adding that.