Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/PickerInput/Popup/PopupPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export type PopupPanelProps<DateType extends object = any> = MustProp<DateType>
FooterProps<DateType> & {
multiplePanel?: boolean;
range?: boolean;
cellHoverValue?: DateType[];

onPickerValueChange: (date: DateType) => void;
};
Expand All @@ -30,6 +31,7 @@ export default function PopupPanel<DateType extends object = any>(
onSubmit,
range,
hoverValue,
cellHoverValue,
} = props;
const { prefixCls, generateConfig } = React.useContext(PickerContext);

Expand Down Expand Up @@ -72,6 +74,7 @@ export default function PopupPanel<DateType extends object = any>(

if (range) {
pickerProps.hoverRangeValue = hoverValue;
pickerProps.hoverValue = cellHoverValue;
} else {
pickerProps.hoverValue = hoverValue;
}
Expand Down
8 changes: 7 additions & 1 deletion src/PickerInput/RangePicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ function RangePicker<DateType extends object = any>(
triggeredFields,
triggerRangeValueChange,
resetRangeValueChange,
currentFieldModified,
] = useRangeValueChange(
enabledFieldCount,
needConfirm,
Expand Down Expand Up @@ -502,6 +503,10 @@ function RangePicker<DateType extends object = any>(
return internalHoverValues || calendarValue;
}, [calendarValue, internalHoverValues]);

const keepCurrentSelection = needConfirm && currentFieldModified && hoverSource === 'cell';
const panelHoverValues = keepCurrentSelection ? calendarValue : hoverValues;
const activeHoverValue = internalHoverValues?.[activeIndex];

// Clean up `internalHoverValues` when closed
React.useEffect(() => {
if (!mergedOpen) {
Expand Down Expand Up @@ -640,7 +645,8 @@ function RangePicker<DateType extends object = any>(
defaultOpenValue={toArray(showTime?.defaultOpenValue)[activeIndex]}
onPickerValueChange={setCurrentPickerValue}
// Hover
hoverValue={hoverValues}
hoverValue={panelHoverValues}
cellHoverValue={keepCurrentSelection && activeHoverValue ? [activeHoverValue] : null}
onHover={onPanelHover}
// Submit
needConfirm={needConfirm}
Expand Down
5 changes: 5 additions & 0 deletions src/PickerInput/hooks/useRangeValueChange.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export type UseRangeValueChangeReturn<FieldValue> = [
triggeredFields: number[],
triggerChange: TriggerChange<FieldValue>,
reset: VoidFunction,
currentFieldModified: boolean,
];

interface TriggeredField {
Expand Down Expand Up @@ -509,6 +510,9 @@ export default function useRangeValueChange<FieldValue = unknown>(
lastValidIndexRef.current = currentIndex ?? lastValidIndexRef.current ?? 0;

const triggeredFields = triggeredFieldsRef.current.map((field) => field.index);
const currentFieldModified = triggeredFieldsRef.current.some(
(field) => field.index === currentIndex && field.modified,
);

return [
currentIndex,
Expand All @@ -517,5 +521,6 @@ export default function useRangeValueChange<FieldValue = unknown>(
triggeredFields,
triggerChange,
reset,
currentFieldModified,
];
}
16 changes: 16 additions & 0 deletions tests/range.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,22 @@ describe('Picker.Range', () => {
expect(findCell(end)).not.toHaveClass('rc-picker-cell-range-end');
});
});

it('should keep the pending selection when hovering with confirmation', async () => {
const { container } = render(<DayRangePicker showTime />);
openPicker(container);
selectCell(11);

expect(findCell(11)).toHaveClass('rc-picker-cell-range-start');

fireEvent.mouseEnter(findCell(22));
await waitFakeTimer();

expect(container.querySelectorAll('input')[0]).toHaveValue('1990-09-22 00:00:00');
expect(findCell(11)).toHaveClass('rc-picker-cell-range-start');
expect(findCell(22)).toHaveClass('rc-picker-cell-hover');
expect(findCell(22)).not.toHaveClass('rc-picker-cell-range-start');
});
});

it('should close when user focus out', () => {
Expand Down
Loading