refactor: use shared renderability guards - #1009
Conversation
|
@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Walkthrough本次变更升级 ChangesReact 节点可渲染性统一
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change standardizes picker renderability checks and updates the utility dependency that supplies them. Non-renderable custom nodes are omitted or fall back to the existing clear control, while the panel non-null checks retain their prior behavior; no current merge-blocking risk is identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 8 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
=======================================
Coverage 98.87% 98.88%
=======================================
Files 68 68
Lines 2857 2859 +2
Branches 815 811 -4
=======================================
+ Hits 2825 2827 +2
Misses 29 29
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yoyo837
left a comment
There was a problem hiding this comment.
Reviewed the renderability semantics, helper selection, dependency floor, existing feedback, and completed CI results. The implementation looks correct. The Vercel failure is limited to team deployment authorization and is not a code or build failure.
说明
isReactRenderable统一判断 footer、prefix、suffix icon 和 clear icon 等 ReactNode 是否需要渲染isNonNullable替换面板与时间选择逻辑中的本地非空判断@rc-component/util的最低版本提升到首次提供这些 helper 的^1.13.0验证
npm run tscnpm run lintnpm test -- tests/components.spec.tsx tests/panel.spec.tsx tests/picker.spec.tsx tests/range.spec.tsx --runInBandSummary by CodeRabbit