refactor: use renderable guard for suffix - #337
Conversation
|
@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Walkthrough升级 ChangesMentions 后缀渲染处理
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Mentions suffix handling now consistently accepts React-renderable values such as 0 and NaN while preserving input compatibility through Fragment wrapping. The required utility dependency is updated accordingly, and no current merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 8 8
Lines 304 305 +1
Branches 82 83 +1
=======================================
+ Hits 299 300 +1
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yoyo837
left a comment
There was a problem hiding this comment.
Reviewed the renderability semantics, helper selection, dependency floor, existing feedback, and completed CI results. The implementation looks correct. The Vercel failure is limited to team deployment authorization and is not a code or build failure.
说明
isReactRenderable统一判断 suffix 是否需要渲染0、NaN等有效 React 内容@rc-component/input@1.3.1的 suffix 判断@rc-component/util的最低版本提升到首次提供该 helper 的^1.13.0验证
npm run tscnpm test -- --runInBandgit diff --check关联 ant-design/ant-design#59193
Summary by CodeRabbit
错误修复
依赖更新