feat: structured dead-code detection pipeline with multi-mode output#149
Draft
nextlevelshit wants to merge 1 commit intomainfrom
Draft
feat: structured dead-code detection pipeline with multi-mode output#149nextlevelshit wants to merge 1 commit intomainfrom
nextlevelshit wants to merge 1 commit intomainfrom
Conversation
…ulti-mode output Rewrite the dead-code detection pipeline into a family of 4 pipelines supporting structured JSON output, PR comments, and GitHub issue creation. Schema changes: - Expand dead-code-scan schema with new categories (duplicate, stale_glue, hardcoded_value), line_range object, and suggested_action field - Create dead-code-report schema for formatted markdown reports - Create dead-code-pr-result schema for PR comment results - Create dead-code-issue-result schema for GitHub issue results Pipeline changes: - Rewrite dead-code.yaml as scan + format (local JSON report) - Create dead-code-pr.yaml: scan + format + publish PR comment - Create dead-code-issue.yaml: scan + format + create GitHub issue - Create dead-code-heal.yaml: preserves existing clean/verify/create-pr flow Persona changes: - Extend github-commenter with gh pr comment and gh issue create permissions - Replace overly broad gh pr* deny with specific denials Tests: - Schema validation tests covering all new categories, fields, and backward compatibility - Pipeline YAML parse tests verifying loading, DAG validation, persona references, and tool requirements
a00fea4 to
0c8682c
Compare
Collaborator
Author
Code Review (Wave Pipeline)Verdict: REQUEST_CHANGES Blocking Issues
Non-Blocking ImprovementsFour non-blocking improvements were also surfaced:
Positive ObservationsOverall quality of the committed fix was noted positively by both reviewers. AssessmentThe implementation is too shallow and too destructive; may need full re-implementation. Generated by Wave code-review pipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dead-code.yaml), PR comment (dead-code-pr.yaml), GitHub issue (dead-code-issue.yaml), and heal (dead-code-heal.yaml)dead-code-scan.schema.jsoncontract with new detection categories (duplicate, stale_glue, hardcoded_value), line range support, and suggested actionsdead-code-report,dead-code-pr-result, anddead-code-issue-resultgithub-commenterpersona permissions inwave.yamlto support PR commentingCloses #135
Changes
.wave/contracts/dead-code-scan.schema.json— Expanded with new categories, line_range, suggested_action fields.wave/contracts/dead-code-report.schema.json— New schema for formatted markdown report output.wave/contracts/dead-code-pr-result.schema.json— New schema for PR comment posting result.wave/contracts/dead-code-issue-result.schema.json— New schema for GitHub issue creation result.wave/pipelines/dead-code.yaml— Rewritten as scan-only + local format pipeline (removed clean/verify/create-pr steps).wave/pipelines/dead-code-pr.yaml— New pipeline: scan + format + publish PR comment.wave/pipelines/dead-code-issue.yaml— New pipeline: scan + format + create GitHub issue.wave/pipelines/dead-code-heal.yaml— New pipeline: extracted heal flow from original dead-code pipelinewave.yaml— Extended github-commenter persona withgh pr comment*permissioninternal/contract/dead_code_schemas_test.go— Schema validation tests for all contract schemasinternal/pipeline/dead_code_pipelines_test.go— Pipeline YAML parse and dependency resolution testsspecs/135-dead-code-pipeline/— Spec, plan, and task artifactsTest Plan
internal/contract/andinternal/pipeline/packages