XER10-2533 : Observed duplicates of login message in admin page #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Removed the duplicate variable Test Procedure: Verify the webui login Risks: Medium Signed-off-by: AnanthaC <anantha_chelladurai@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a duplicate HTML element ID issue in the login page. Previously, two different paragraph elements on the same page both used id="index_helptext", which violates HTML standards requiring unique IDs within a page and could cause duplicate message display issues.
Changes:
- Renamed the ID of the password tip message from
index_helptexttoindex_helptext_tipto ensure unique IDs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/Styles/xb6/jst/index.jst | Updated ID attribute for the password tip paragraph from index_helptext to index_helptext_tip |
| source/Styles/xb3/jst/index.jst | Updated ID attribute for the password tip paragraph from index_helptext to index_helptext_tip |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Removed the duplicate variable
Test Procedure: Verify the webui login
Risks: Medium