RDKEMW-10467: Fix Invalid time values caused by drift #212

shivabhaskar · 2025-11-19T11:46:54Z

Reason for Change: Changing CLOCK_REALTIME to CLOCK_MONOTONIC to avoid clock drifts impact in the calculations
Test Procedure: When Telemetry report generation is in progress change the time. The processing time should have a valid value
Risks: Low
Priority: P1

Copilot

Pull Request Overview

This PR fixes invalid time values in telemetry report generation caused by system clock drift by changing timing measurements from CLOCK_REALTIME to CLOCK_MONOTONIC.

Changed all elapsed time measurements from CLOCK_REALTIME to CLOCK_MONOTONIC to prevent clock drift from affecting duration calculations
Improved log messages in profilexconf.c for better clarity and consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
source/bulkdata/profilexconf.c	Updated three `clock_gettime` calls to use `CLOCK_MONOTONIC` for measuring start time, processing time, and elapsed time; improved log messages for execution count and processing time
source/bulkdata/profile.c	Updated two `clock_gettime` calls to use `CLOCK_MONOTONIC` for measuring start and end times of report collection and generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dharshini555 · 2025-11-19T11:55:58Z

Code changes looks good to me.

rdkcmf-jenkins · 2025-11-19T11:56:14Z

Coverity Issue - Data race condition

Accessing "profile->grepSeekProfile->execCounter" without holding lock "plMutex". Elsewhere, "_GrepSeekProfile.execCounter" is written to with "plMutex" held 2 out of 2 times.

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
source/bulkdata/profile.c:339

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profile.c

        else
        {
            T2Error("Unsupported encoding format : %s\n", profile->encodingType);
        }


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profile.c

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profilexconf.c

            {
                encodeEventMarkersInJSON(valArray, profile->eMarkerList);
            }
            profile->grepSeekProfile->execCounter += 1;


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profilexconf.c

        else
        {
            T2Warning("Failed to save grep config to file for profile: %s\n", profile->name);
        }


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profilexconf.c

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-11-24T11:15:01Z

source/bulkdata/profile.c

        else
        {
            T2Error("Unsupported encoding format : %s\n", profile->encodingType);
        }


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-11-24T11:15:01Z

source/bulkdata/profile.c

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-24T12:47:32Z

source/bulkdata/profilexconf.c

+            clockReturn |= clock_gettime(CLOCK_MONOTONIC, &endTime);
+            if(clockReturn)
+            {
+                T2Warning("Error in Fetching the time Elapsed");


The error message "Error in Fetching the time Elapsed" is grammatically incorrect and unclear. Consider revising to "Error fetching elapsed time" or "Failed to get time from clock_gettime()" to be more concise and accurate.

Suggested change

T2Warning("Error in Fetching the time Elapsed");

T2Warning("Failed to get time from clock_gettime()");

source/bulkdata/profilexconf.c

Copilot · 2025-11-24T12:47:32Z

source/bulkdata/profilexconf.c

+        clockReturn |= clock_gettime(CLOCK_MONOTONIC, &endTime);
+        if (clockReturn)
+        {
+            T2Warning("Error in Fetching the time Elapsed");


The error message "Error in Fetching the time Elapsed" is grammatically incorrect and unclear. Consider revising to "Error fetching elapsed time" or "Failed to get time from clock_gettime()" to be more concise and accurate.

Suggested change

T2Warning("Error in Fetching the time Elapsed");

T2Warning("Failed to get time from clock_gettime()");

source/bulkdata/profile.c

Copilot · 2025-11-24T12:47:33Z

source/bulkdata/profile.c

+        clockReturn |= clock_gettime(CLOCK_MONOTONIC, &endTime);
+        if(clockReturn)
+        {
+            T2Warning("Error in Fetching the time Elapsed");


The error message "Error in Fetching the time Elapsed" is grammatically incorrect and unclear. Consider revising to "Error fetching elapsed time" or "Failed to get time from clock_gettime()" to be more concise and accurate.

Suggested change

T2Warning("Error in Fetching the time Elapsed");

T2Warning("Failed to get time from clock_gettime()");

source/bulkdata/profilexconf.c

…ONIC Reason for Change: Changing CLOCK_REALTIME to CLOCK_MONOTONIC to avoid clock drifts impact in the calculations Test Procedure: When Telemetry report generation is in progress change the time. The processing time should have a valid value Risks: Low Priority: P1

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-17T21:29:17Z

source/bulkdata/profilexconf.c

+        int clockReturn = 0;
+        clockReturn = clock_gettime(CLOCK_MONOTONIC, &startTime);


The return value of the first clock_gettime call is not checked. If the first call fails, clockReturn will be non-zero, but the code continues execution. This could lead to using uninitialized startTime values in later calculations. Consider checking the return value immediately after the first call or initializing clockReturn to ensure both calls are checked properly.

Copilot AI review requested due to automatic review settings November 19, 2025 11:46

shivabhaskar requested a review from a team as a code owner November 19, 2025 11:46

Copilot started reviewing on behalf of shivabhaskar November 19, 2025 11:48 View session

Copilot finished reviewing on behalf of shivabhaskar November 19, 2025 11:49

Copilot AI reviewed Nov 19, 2025

View reviewed changes

rdkcmf-jenkins reviewed Nov 19, 2025

View reviewed changes

rdkcmf-jenkins reviewed Nov 24, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 24, 2025 12:44

Copilot started reviewing on behalf of shivabhaskar November 24, 2025 12:44 View session

Copilot finished reviewing on behalf of shivabhaskar November 24, 2025 12:46

Copilot AI reviewed Nov 24, 2025

View reviewed changes

shibu-kv approved these changes Nov 26, 2025

View reviewed changes

shivabhaskar added 3 commits December 17, 2025 13:25

Coverity Fix

ec64c37

Fix Formatting and Coverity

d048d01

Copilot AI review requested due to automatic review settings December 17, 2025 21:25

shibu-kv force-pushed the topic/RDKEMW-10467 branch from 9a7e5ba to d048d01 Compare December 17, 2025 21:25

Copilot started reviewing on behalf of shibu-kv December 17, 2025 21:25 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Merge branch 'develop' into topic/RDKEMW-10467

7d5d223

	T2Warning("Error in Fetching the time Elapsed");
	T2Warning("Failed to get time from clock_gettime()");

		int clockReturn = 0;
		clockReturn = clock_gettime(CLOCK_MONOTONIC, &startTime);

RDKEMW-10467: Fix Invalid time values caused by drift #212

Are you sure you want to change the base?

RDKEMW-10467: Fix Invalid time values caused by drift #212

Uh oh!

Conversation

shivabhaskar commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dharshini555 commented Nov 19, 2025

Uh oh!

rdkcmf-jenkins commented Nov 19, 2025

Coverity Issue - Data race condition

Issue location

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

rdkcmf-jenkins Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

rdkcmf-jenkins Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 24, 2025 •

edited

Loading

rdkcmf-jenkins Nov 24, 2025 •

edited

Loading