Reduce console logging when logging is false#1
Open
bdnstn wants to merge 13 commits into
Open
Conversation
Replace accidently deleted line 116.
Sorry for the noise. I didn't realize my commits were all being included in the PR #1. I should have created a branch.
update mqtt version in package.json - old version number was causing null object error on server id.
`TERMINATERAMP` is the command in the C-Bus, so it make sense to use it in MQTT also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running cgateweb inside a Home Assistant Add-On on a Raspberry Pi. With
loggingset tofalseI expect to see fewer console messages, but instead I get thousands onNOOPmessages logged. Console output in this environment gets written to the add-on log on the (fragile) SD card. It is unnecessary and inappropriate whenloggingisfalse.