Skip to content

Review color contrast and update default colors #2

Description

@lukehler

I was a bit surprised that #000 on #777 (the hover state for a bar chart) passes AA, but that doesn't change the fact that it's a bit tough to read. For the scatter plots, --default-light-background works out to #f1f1fe on a white background (and varies widely based upon what's behind it) and - while admittedly not being used for text - the contrast ratio is very low, making the markers difficult to distinguish.

While these are clearly intended to be overridden in practical use (using custom properties makes it very easy to do so), it does seem that having higher contrast defaults might better demonstrate the intent. Though semantically sound, it seems like there's still more that could be done to help illustrate the idea.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions