Repository navigation
Allow OpenSSL 4 for Rubies that support it - #2647
Merged
Merged
Conversation
Ruby/OpenSSL 3.2.4, 3.3.3 and 4.0.2 added OpenSSL 4 support and ship with Ruby 3.3.12, 3.4.10 and 4.0.6. Widen the needs_openssl upper bound to 4.x.x for those releases and later, including the matching development definitions, so an installed OpenSSL 4 is used instead of vendoring OpenSSL 3. Make update-cruby apply the same boundaries to new definitions, and cover a 4.x.x upper bound in the build tests. Signed-off-by: Patrick Linnane <patrick@linnane.io>
2 of 21 tasks
mislav
approved these changes
Oct 16, 2026
mislav
left a comment
mislav
left a comment
Member
There was a problem hiding this comment.
This looks great to me. Thanks for the heads up and for the changeset!
Member
|
I will look this at next week 👌 |
Member
|
I built 3.3.12, 3.4.10, 3.4.11, 4.0.6, 4.0.7 and 4.1.0-preview1 from this branch on macOS (arm64) with both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby/OpenSSL 3.2.4, 3.3.3 and 4.0.2 added OpenSSL 4 support and are bundled with Ruby 3.3.12, 3.4.10 and 4.0.6. This widens the needs_openssl upper bound to 4.x.x for those releases and later, including 3.3-dev, 3.4-dev, 4.0-dev, 4.1-dev and ruby-dev, so an installed OpenSSL 4 from the system, pkg-config or Homebrew is used instead of vendoring OpenSSL 3. When both openssl@3 and openssl@4 are installed from Homebrew, these Rubies now link to openssl@4. Older definitions keep their existing bounds and vendored fallbacks.
script/update-cruby applies the same boundaries to new definitions, and two tests in test/build.bats cover a 4.x.x bound.
Verified by building 3.3.12, 3.4.10, 4.0.6 and 4.1.0-preview1 against OpenSSL 4.0.3 on macOS (Homebrew openssl@4) and Ubuntu 24.04 (pkg-config). Each loaded OpenSSL 4.0.3 at runtime and passed its bundled openssl test suite.