Skip to content

Set -x flag for release script to show commands being run #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 1 commit into from
Sep 15, 2026
Merged

Set -x flag for release script to show commands being run #2639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# - creates a new Release on GitHub
# - [automated] a GitHub Action will create a Homebrew PR for the new release

set -e
set -ex

@jasonkarns jasonkarns Sep 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on using something like:

[ -n "${DEBUG-}" ] && set -x

So that the extra debug/tracing output is opt-in rather than always on?

@eregon eregon Sep 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a use case for wanting to not see the extra output?
I think the extra output doesn't matter if it works, but it's important to be there if it fails.
Having it only after setting DEBUG is too late.


git fetch -q --tags origin master
git checkout -q master
Expand Down