Skip to content

Fix removing -O3 on ruby-dev and Ruby < 3.2 on Fedora 42+ #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mislav merged 4 commits into from
Sep 2, 2026
+11 −3
Merged

Fix removing -O3 on ruby-dev and Ruby < 3.2 on Fedora 42+ #2638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5060d0f
Use the cflags configure variable for the -std=gnu17 workaround
eregon Aug 31, 2026
692136b
Let CFLAGS override everything, it's the purpose of CFLAGS
eregon Aug 31, 2026
7177e5c
Clarify that RUBY_CFLAGS overrides Ruby's default CFLAGS
eregon Aug 31, 2026
5b39cda
Treat the dev version as newer than any release in normalize_semver
eregon Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ The build process may be configured through the following environment variables:
| `RUBY_BUILD_ROOT` | The path prefix to search for build definitions files. *Deprecated:* use `RUBY_BUILD_DEFINITIONS`|
| `RUBY_BUILD_VENDOR_OPENSSL` | Build and vendor openssl even if the system openssl is compatible |
| `CC` | Path to the C compiler. |
| `RUBY_CFLAGS` | Additional `CFLAGS` options (_e.g.,_ to override `-O3`). |
| `RUBY_CFLAGS` | Overrides Ruby's default `CFLAGS`, including `-O3` (beware: without a `-O` flag Ruby is built unoptimized). To add flags, use `RUBY_CONFIGURE_OPTS=cflags=...` instead |
| `CONFIGURE_OPTS` | Additional `./configure` options. |
| `MAKE` | Custom `make` command (_e.g.,_ `gmake`). |
| `MAKE_OPTS` / `MAKEOPTS` | Additional `make` options. |
Expand Down
12 changes: 10 additions & 2 deletions bin/ruby-build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,11 @@ build_package_standard() {
#
# TODO: Consider changing this to check for GCC v15 specifically
# rather than inspecting the OS itself.
export CFLAGS="-std=gnu17 $CFLAGS"

# Use the cflags configure variable, which Ruby's configure appends to
# its default optflags/debugflags/warnflags, unlike CFLAGS which would
# override them and notably lose the -O3, producing a -O0 Ruby.
export cflags="-std=gnu17 $cflags"
fi
# ./configure --prefix=/path/to/ruby
# shellcheck disable=SC2086,SC2153
Expand Down Expand Up @@ -1169,7 +1173,11 @@ homebrew_openssl_versions() {
# Example: 3.1.23 -> 30123
# See also osx_version, require_java
normalize_semver() {
awk -F. '{print $1 * 10000 + $2 * 100 + $3}' <<<"$1"
if [ "$1" = "dev" ]; then
echo 99999999
else
awk -F. '{print $1 * 10000 + $2 * 100 + $3}' <<<"$1"
fi
}

# Checks if system OpenSSL does NOT satisfy the version requirement
Expand Down