Fix: guard REQUESTS_SILENCE_PSR0_DEPRECATIONS define to prevent constant collision#416
Open
N-M wants to merge 1 commit into
Open
Fix: guard REQUESTS_SILENCE_PSR0_DEPRECATIONS define to prevent constant collision#416N-M wants to merge 1 commit into
N-M wants to merge 1 commit into
Conversation
…ant collision Unconditional define() causes a fatal error when the constant is already defined by the host environment (e.g. WordPress core defines it in its bundled Requests library before the Composer autoloader runs). Razorpay.php in the same package already uses this guard correctly; align Deprecated.php to match. Fixes razorpay#415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deprecated.phpdefinesREQUESTS_SILENCE_PSR0_DEPRECATIONSunconditionally:If another package or the host environment has already defined this constant before the Composer autoloader runs, PHP throws a fatal error:
A common case is WordPress, which defines this constant in its bundled Requests library before any plugin's autoloader is executed.
Fix
Wrap the
define()with a!defined()guard — the same pattern already used inRazorpay.phpin this package:Closes #415