Skip to content

[FIX] validateWebhookSignature possible timing attack #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rajivnayanc wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[FIX] validateWebhookSignature possible timing attack #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/utils/razorpay-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ function validateWebhookSignature (body, signature, secret) {
* @return {Boolean}
*/

var crypto = require("crypto");

if (!isDefined(body) ||
!isDefined(signature) ||
!isDefined(secret) ) {
Expand All @@ -98,8 +96,15 @@ function validateWebhookSignature (body, signature, secret) {
var expectedSignature = crypto.createHmac('sha256', secret)
.update(body)
.digest('hex');

const signatureBuffer = Buffer.from(signature);
const expectedSignatureBuffer = Buffer.from(expectedSignature);

if (signatureBuffer.length !== expectedSignatureBuffer.length) {
return false;
}

return expectedSignature === signature;
return crypto.timingSafeEqual(signatureBuffer, expectedSignatureBuffer);
}

function validatePaymentVerification(params={}, signature, secret){
Expand Down