Skip to content

fix: add upstream timeout and body size limit to API proxy #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohilsurana wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add upstream timeout and body size limit to API proxy #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5922c22
fix: add upstream timeout and body size limit to API proxy
rohilsurana Jun 5, 2026
b8a9be3
fix: decode path before traversal check to catch encoded variants
rohilsurana Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/chronicle/src/server/api/apis-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,19 @@ interface ProxyRequest {
body?: unknown;
}

const MAX_BODY_BYTES = 50 * 1024 * 1024;
const UPSTREAM_TIMEOUT_MS = 120_000;

export default defineHandler(async event => {
if (event.req.method !== 'POST') {
throw new HTTPError({ status: 405, message: 'Method not allowed' });
}

const contentLength = Number(event.req.headers.get('content-length') ?? '0');
if (contentLength > MAX_BODY_BYTES) {
throw new HTTPError({ status: 413, message: 'Request body too large' });
}
Comment thread
rohilsurana marked this conversation as resolved.

const { specName, method, path, headers, body } =
(await event.req.json()) as ProxyRequest;

Expand All @@ -33,7 +41,8 @@ export default defineHandler(async event => {
throw new HTTPError({ status: 404, message: `Unknown spec: ${specName}` });
}

if (/^[a-z]+:\/\//i.test(path) || path.includes('..')) {
const decoded = decodeURIComponent(path);
if (/^[a-z]+:\/\//i.test(decoded) || decoded.includes('..')) {
throw new HTTPError({ status: 400, message: 'Invalid path' });
}

Expand All @@ -43,7 +52,8 @@ export default defineHandler(async event => {
const response = await fetch(url, {
method,
headers,
body: body ? JSON.stringify(body) : undefined
body: body ? JSON.stringify(body) : undefined,
Comment thread
rohilsurana marked this conversation as resolved.
signal: AbortSignal.timeout(UPSTREAM_TIMEOUT_MS),
});

const contentType = response.headers.get('content-type') ?? '';
Expand Down
Loading