Repository navigation
Conversation
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
October 20, 2026 16:26
d8d3b45 to
12ece38
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
October 20, 2026 16:51
12ece38 to
86820c4
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
October 20, 2026 17:14
86820c4 to
4dfecca
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
2 times, most recently
from
October 21, 2026 04:58
e737c9f to
5be43d0
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
October 29, 2026 14:07
5be43d0 to
f1b6a45
Compare
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
October 29, 2026 14:16
f1b6a45 to
13bb72d
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
October 29, 2026 14:37
13bb72d to
dcdb40a
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 7, 2026 08:16
201655c to
6c226ac
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 7, 2026 08:55
6c226ac to
0c77a97
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 7, 2026 10:01
0c77a97 to
acdca68
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 7, 2026 10:42
acdca68 to
8352421
Compare
Contributor
Author
|
bugbot run |
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 7, 2026 11:22
8352421 to
1e8637f
Compare
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1e8637f. Configure here.
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 8, 2026 23:34
1e8637f to
55895a0
Compare
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 9, 2026 02:07
55895a0 to
25ed92a
Compare
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 9, 2026 05:45
25ed92a to
63aa1ac
Compare
marwan116
force-pushed
the
marwan/mcap-dsv2-video-messages
branch
from
November 9, 2026 15:18
63aa1ac to
31cc5fc
Compare
Problem: - A read of paths returned each video message as an encoded payload. A frame needs the frames back to its keyframe to decode, and a read task can start mid-GOP, so a row could not be decoded on its own. Change: - read_mcap(paths, video=VideoOptions(resize=...)) decodes the video topics in the read task. Each video message becomes a row with a frame column, a uint8 (height, width, 3) image, in place of data; video_topics lists topics with unknown schema names. - A task that starts mid-GOP first reads back to the last keyframe at or before its first frame (RAY_DATA_MCAP_MAX_LEAD_IN_S back at most), and decodes those frames without emitting them. - Every frame becomes a row, however the file is split into tasks. A picture with no keyframe in reach has a null frame. For a lower rate, a sample read with steps.across(fps=...) over clips of each recording picks the frames. - With max_errored_blocks set, a corrupt chunk a task owns is recorded and skipped, as a plain read does, and its cameras have null frames until their next keyframe. A look-back stops at a corrupt chunk. - Planning fails early when a selected channel is not decodable video. Without resize, it types the frame column from the first keyframes of the sampled files. - count() of decoded rows reads the files, and attachment and metadata reads refuse video. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Marwan Sarieddine <sarieddine.marwan@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem.
Change.
RAY_DATA_MCAP_MAX_LEAD_IN_Sback at most). It decodes those frames without emitting them. The read-back goes only as far as the keyframe, nearest chunk first, and cameras that share chunks parse each chunk once.frameis selected. A picture the codec rejects, or whose frame never comes out, gets a nullframe.frame.max_errored_blocksset, a corrupt chunk a task owns is recorded and skipped, as a plain read does. Its cameras have null frames until their next keyframe, and a look-back stops at a corrupt chunk.steps.across(fps=...)over clips cut from each recording.framecolumn's type follows fromresizealone, so planning decodes no keyframe. Withoutresize, the column is variable-shaped. Withresize, it is fixed-shape, in theDataContext's tensor format.count()of decoded rows reads the files, and attachment and metadata reads refusevideo.Decisions to confirm:
fpsmeans only aTopicSpec's step rate. A lower rate goes through a sample read.Related issues
Additional information
737 passed, 32 skipped. pre-commit and pyrefly clean.
AI assistance (Claude Code) was used to draft this change; I reviewed every line and ran the tests above locally.
🤖 Generated with Claude Code