Repository navigation
[Data] Keep a map task's buffered rows when max_errored_blocks skips its error; read past corrupt MCAP chunks #67167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
140d260
[Data] Emit a map task's buffered rows before an error the job skips
marwan116 14660c2
[Data] read_mcap V2: read past a corrupt chunk when errors are skipped
marwan116 3e0b902
[Data] Emit a partial block when an actor task won't be rerun
marwan116 fbff351
[Data] Emit a partial block on a system error Ray won't rerun
marwan116 b546f17
[Data] Keep a fused batcher's rows and rerun by default on a skipped …
marwan116 18be598
[Data] read_mcap: skip only corrupt chunks and raise other errors at …
marwan116 ab54d41
[Data] read_mcap: fold the partial-block rerun tests into one; trim d…
marwan116 9e15f8c
[Data] read_mcap: skip one message that is not JSON, not its file
marwan116 38d54b5
[Data] read_mcap: keep the limit and the rows built when skipping
marwan116 8f45b93
[Data] read_mcap: skip an unselected channel before its schema
marwan116 ff354e8
[Data] read_mcap: keep one error for a file's corrupt chunks
marwan116 f913090
[Data] read_mcap: find the file name in the error's notes
marwan116 8132257
[Data] read_mcap: check the corrupt chunk's error, not its notes
marwan116 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.