[core] Add local:// runtime_env URIs for code already in node - #65245
[core] Add local:// runtime_env URIs for code already in node#65245YashwanthRanjanSingaravel wants to merge 7 commits into
Conversation
Signed-off-by: YashwanthRanjanSingaravel <yashwanth.ranjansingaravel@anyscale.com>
YashwanthRanjanSingaravel
added
the
go
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for "local://" URIs in "working_dir" and "py_modules" within Ray's runtime environments, allowing the use of directories already present on all cluster nodes without packaging or uploading them. The review feedback highlights several Windows-specific issues, including a command execution failure when paths contain spaces, and multiple test failures due to Unix-style absolute paths not being recognized as absolute on Windows. Suggestions are provided to make both the runtime execution and the test suite fully cross-platform.
Signed-off-by: YashwanthRanjanSingaravel <yashwanth.ranjansingaravel@anyscale.com>
…anSingaravel/ray into feat/image-workdir-support
There was a problem hiding this comment.
Code Review
This pull request introduces support for local:// URIs in runtime_env (working_dir and py_modules), allowing users to reference directories already present on all cluster nodes (such as those baked into container images) without uploading or downloading them. Feedback highlights a potential issue on Windows where using subprocess.list2cmdline to quote paths for cmd.exe shell execution (such as cd) can fail if the path contains shell metacharacters like & but no spaces, suggesting wrapping the path in double quotes directly instead.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b969152. Configure here.
ray-gardener
Bot
added
docs
1 participant
Description
local://runtime_env URI:working_dir: local:///appChanges
Protocol.LOCAL:parse_urireturns the path itself, rejects non absolute paths.working_dir/py_modules: no upload or download, 0 bytes cached, never deleted.