Revert checksum validation + stamp shim commit id - #15
Open
shreyanshjain7174 wants to merge 3 commits into
Open
Conversation
added 2 commits
June 11, 2026 15:20
This reverts commit c4ac843.
The shim's -v showed an empty Revision because the build populated neither the embedded internal/version/data files nor -ldflags -X overrides. Fall back to the git revision that 'go build' embeds automatically (debug.ReadBuildInfo vcs.*), so the runhcs-v1 shim reports the commit it was built from.
shreyanshjain7174
changed the title
Comment out options.ChecksumVerification = opt.ChecksumVerification so no caller can activate memory-page checksum validation during live migration, even if the proto request sets it. With the omitempty tag the field is omitted from the HCS payload entirely. Signed-off-by: Shreyansh Sancheti <shsancheti@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
Revert "Enable checksum validation in HCS Live Migration" (c4ac843) - that was a canary diagnostic that hardcoded ChecksumVerification=true and set the migration CRC reg keys. Restores the original option-driven behaviour. For the ACI package we want checksum validation off.
version: fall back to the VCS revision that
go buildembeds, so the runhcs-v1 shim's-vshows the commit it was built from instead of an empty Revision.Builds clean; shim
-vnow printscommit: <sha>.For ACI packaging work item #38387077.