Document that project config apply can create the project - #61
Conversation
Co-Authored-By: brandon <brandon@flightcontrol.dev>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
| # Already have a config file? Skip `project create`: apply creates the project when it does not | ||
| # exist yet and the file's project.givenId matches the given ID you pass here. |
There was a problem hiding this comment.
For a new project with an existing config file, this comment says to skip only project create, leaving the linear workflow to pull configuration from a project that does not exist before reaching the apply command that creates it. Explicitly skip both preceding commands for this path so the generated instructions are internally consistent.
| # Already have a config file? Skip `project create`: apply creates the project when it does not | |
| # exist yet and the file's project.givenId matches the given ID you pass here. | |
| # Already have a config file? Skip `project create` and `project config pull`: apply creates the | |
| # project when it does not exist yet and the file's project.givenId matches the given ID passed here. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .mintlify/assistant/skills/deploy-an-app/skill.md
Line: 68-69
Comment:
**Skip the pull command too**
For a new project with an existing config file, this comment says to skip only `project create`, leaving the linear workflow to pull configuration from a project that does not exist before reaching the apply command that creates it. Explicitly skip both preceding commands for this path so the generated instructions are internally consistent.
```suggestion
# Already have a config file? Skip `project create` and `project config pull`: apply creates the
# project when it does not exist yet and the file's project.givenId matches the given ID passed here.
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Good catch — config pull against a nonexistent project can't work either. Applied your suggestion in 3cff067.
Co-Authored-By: brandon <brandon@flightcontrol.dev>
Co-Authored-By: brandon <brandon@flightcontrol.dev>
Summary
ravion project config apply <project-id>now creates the project when it does not exist yet and the config file'sproject.givenIdmatches<project-id>(--dry-runplans that creation without writing), soravion project createis no longer a required first step when you already have a config file. Adds that note to the pull-and-apply steps and the deploy-an-app assistant skill, and regenerates theproject config applyhelp text on the CLI reference page.Depends on https://github.com/ravionhq/flightcontrol/pull/7045 — merge after that ships.
ENG-5202
Link to Devin session: https://app.devin.ai/sessions/5f8b39c935554413a00acb3020a9254e
Requested by: @flybayer
Greptile Summary
The PR documents that
ravion project config applycan create a missing project when its given ID matches the config, including dry-run behavior.Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking clarification needed in the deployment assistant’s alternative command flow.
The reference and config guide describe the new behavior consistently, but the assistant skill still directs the skip-create path through an unconditional pull from the not-yet-created project.
Files Needing Attention: .mintlify/assistant/skills/deploy-an-app/skill.md
Important Files Changed
project config pullunconditional in the alternative workflow.Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Document that project config apply can c..." | Re-trigger Greptile