RDBC-1048 Fix silent data corruption bugs in Document Session#285
Merged
poissoncorp merged 4 commits intoravendb:v7.2from Apr 10, 2026
Merged
RDBC-1048 Fix silent data corruption bugs in Document Session#285poissoncorp merged 4 commits intoravendb:v7.2from
poissoncorp merged 4 commits intoravendb:v7.2from
Conversation
7382878 to
a39d405
Compare
poissoncorp
reviewed
Apr 10, 2026
poissoncorp
reviewed
Apr 10, 2026
poissoncorp
reviewed
Apr 10, 2026
poissoncorp
reviewed
Apr 10, 2026
Contributor
|
tests are failing |
a39d405 to
aefbe2b
Compare
Member
Author
|
My bad this one was supposed to be draft. Anyways, fixed it. |
poissoncorp
reviewed
Apr 10, 2026
…checks, and batch patch status handling
…d not propagating cluster transaction index
aefbe2b to
398f400
Compare
poissoncorp
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1048/Silent-data-corruption-bugs-in-Python-client-Document-Session
Additional description
Fix 9 bugs where the client produces wrong results without raising errors:
oroperator misuse (if x == A or B:is always True)orpattern)orpattern)breakinstead ofcontinue)update_session_after_save_changeswas a no-op with a TODO comment (cluster TX index not propagated)Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.
Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.