Skip to content

Trim trailing slash on CloudFront via 301 redirect #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poissoncorp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Trim trailing slash on CloudFront via 301 redirect #2388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4759716
Trim trailing slash on CloudFront via 301 redirect
poissoncorp Apr 3, 2026
3297fbe
Avoid doubled redirects when there's entry in redirects.json
poissoncorp Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions scripts/handle_redirects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ const staticAssetRegex =

const versionRegex = /^\/(\d+\.\d+)(\/.*)?/;

function stripTrailingSlash(uri) {
return uri.endsWith("/") ? uri.slice(0, -1) : uri;
}

function compareVersions(v1, v2) {
const parts1 = v1.split(".");
const parts2 = v2.split(".");
Expand Down Expand Up @@ -42,18 +38,32 @@ function compareVersions(v1, v2) {
}
}

function redirect(targetUrl) {
return {
statusCode: 301,
statusDescription: "Moved Permanently",
headers: {
location: { value: targetUrl },
},
};
}

async function handler(event) {
const request = event.request;
const uri = request.uri;
const normalizedUri = stripTrailingSlash(uri);

if (staticAssetRegex.test(uri)) {
return request;
}

request.uri = normalizedUri + "/index.html";
const hasTrailingSlash = uri !== "/" && uri.endsWith("/");
const normalizedUri = hasTrailingSlash ? uri.slice(0, -1) : uri;

if (normalizedUri.startsWith("/templates")) {
if (hasTrailingSlash) {
return redirect(normalizedUri);
}
request.uri = uri + "/index.html";
return request;
}

Expand All @@ -62,31 +72,29 @@ async function handler(event) {
const redirectData = await kvsHandle.get(normalizedUri);
const redirectJsonValue = JSON.parse(redirectData);
if (redirectJsonValue.targetUrl) {
return {
statusCode: 301,
statusDescription: "Moved Permanently",
headers: {
location: { value: redirectJsonValue.targetUrl },
},
};
return redirect(redirectJsonValue.targetUrl);
}
} catch (_) {
// No redirect rule found — pass through as-is
// No redirect rule found
}
if (hasTrailingSlash) {
return redirect(normalizedUri);
}
request.uri = uri + "/index.html";
return request;
}

const versionMatch = normalizedUri.match(versionRegex);

let version, versionlessUri, targetUri;
let redirectRequired = false;
let redirectRequired = hasTrailingSlash;

if (versionMatch) {
version = versionMatch[1];
versionlessUri = versionMatch[2] || "/";
versionlessUri = versionMatch[2] || "";
} else {
version = defaultVersion;
versionlessUri = normalizedUri;
versionlessUri = normalizedUri === "/" ? "" : normalizedUri;
redirectRequired = true;
}

Expand All @@ -109,14 +117,9 @@ async function handler(event) {
}

if (redirectRequired) {
return {
statusCode: 301,
statusDescription: "Moved Permanently",
headers: {
location: { value: targetUri },
},
};
return redirect(targetUri);
}

request.uri = normalizedUri + "/index.html";
return request;
}
Loading