Add silent mode to suppress progess and log output#2
Open
serrhiy wants to merge 1 commit into
Open
Conversation
In some scenarios, logging output is unnecessary or disruptive. It would be helpful to have an option to disable it. Changes: - Add `silent` parameter to MNISTLoader.__init__() and from_arff() - Create log() helper function that respects silent flag - Pass `disable=silent` to all tqdm progress bars - Replace all print() calls with log() calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some scenarios, logging output is unnecessary or disruptive. It would be helpful to have an option to disable it.
Changes:
silentparameter to MNISTLoader.init() and from_arff()disable=silentto all tqdm progress bars