Skip to content

only check for source files in src/ and test/ for bazel build#2936

Open
kilograham wants to merge 1 commit into
developfrom
relax-bazel-check
Open

only check for source files in src/ and test/ for bazel build#2936
kilograham wants to merge 1 commit into
developfrom
relax-bazel-check

Conversation

@kilograham
Copy link
Copy Markdown
Contributor

@kilograham kilograham requested a review from will-v-pi May 14, 2026 20:12
@kilograham kilograham added this to the 2.2.1 milestone May 14, 2026
@kilograham kilograham changed the title only check for source files in src/ and test/ only check for source files in src/ and test/ for bazel build May 14, 2026
Copy link
Copy Markdown
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the issue you're seeing in #2921 - you also need to change git_ls_files_by_extension to only return files in these paths.

Also, it's not just files under src and test that should be checked, it should also check tools/pioasm, so I think excluding cmake is possibly the better option than explicitly specifying paths to search?

A fix could be to revert this change and just add

bazel_files = [f for f in bazel_files if not f.is_relative_to("cmake")]

before return bazel_files in git_ls_files_by_extension, to exclude the files under cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants