Skip to content

codegen: use GPR_S64 for EE sign-tested branches (BLEZ/BGTZ/BLTZ/BGEZ + variants) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlsandri wants to merge 1 commit into from
Closed

codegen: use GPR_S64 for EE sign-tested branches (BLEZ/BGTZ/BLTZ/BGEZ + variants) #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ps2xRecomp/src/lib/code_generator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,10 @@ namespace ps2recomp
conditionStr = fmt::format("GPR_U64(ctx, {}) != GPR_U64(ctx, {})", rs_reg, rt_reg);
break;
case OPCODE_BLEZ:
conditionStr = fmt::format("GPR_S32(ctx, {}) <= 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) <= 0", rs_reg);
break;
case OPCODE_BGTZ:
conditionStr = fmt::format("GPR_S32(ctx, {}) > 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) > 0", rs_reg);
break;
case OPCODE_BEQL:
conditionStr = fmt::format("GPR_U64(ctx, {}) == GPR_U64(ctx, {})", rs_reg, rt_reg);
Expand All @@ -490,40 +490,40 @@ namespace ps2recomp
conditionStr = fmt::format("GPR_U64(ctx, {}) != GPR_U64(ctx, {})", rs_reg, rt_reg);
break;
case OPCODE_BLEZL:
conditionStr = fmt::format("GPR_S32(ctx, {}) <= 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) <= 0", rs_reg);
break;
case OPCODE_BGTZL:
conditionStr = fmt::format("GPR_S32(ctx, {}) > 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) > 0", rs_reg);
break;
case OPCODE_REGIMM:
switch (rt_reg)
{
case REGIMM_BLTZ:
conditionStr = fmt::format("GPR_S32(ctx, {}) < 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) < 0", rs_reg);
break;
case REGIMM_BGEZ:
conditionStr = fmt::format("GPR_S32(ctx, {}) >= 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) >= 0", rs_reg);
break;
case REGIMM_BLTZL:
conditionStr = fmt::format("GPR_S32(ctx, {}) < 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) < 0", rs_reg);
break;
case REGIMM_BGEZL:
conditionStr = fmt::format("GPR_S32(ctx, {}) >= 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) >= 0", rs_reg);
break;
case REGIMM_BLTZAL:
conditionStr = fmt::format("GPR_S32(ctx, {}) < 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) < 0", rs_reg);
unconditionalLinkCode = fmt::format("SET_GPR_U32(ctx, 31, 0x{:X}u);", fallthroughPc);
break;
case REGIMM_BGEZAL:
conditionStr = fmt::format("GPR_S32(ctx, {}) >= 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) >= 0", rs_reg);
unconditionalLinkCode = fmt::format("SET_GPR_U32(ctx, 31, 0x{:X}u);", fallthroughPc);
break;
case REGIMM_BLTZALL:
conditionStr = fmt::format("GPR_S32(ctx, {}) < 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) < 0", rs_reg);
conditionalLinkCode = fmt::format("SET_GPR_U32(ctx, 31, 0x{:X}u);", fallthroughPc);
break;
case REGIMM_BGEZALL:
conditionStr = fmt::format("GPR_S32(ctx, {}) >= 0", rs_reg);
conditionStr = fmt::format("GPR_S64(ctx, {}) >= 0", rs_reg);
conditionalLinkCode = fmt::format("SET_GPR_U32(ctx, 31, 0x{:X}u);", fallthroughPc);
break;
default:
Expand Down