codegen: remove dead else branch; narrow ps2_recompiled_functions.h include#110
Closed
jlsandri wants to merge 1 commit intoran-j:mainfrom
Closed
codegen: remove dead else branch; narrow ps2_recompiled_functions.h include#110jlsandri wants to merge 1 commit intoran-j:mainfrom
jlsandri wants to merge 1 commit intoran-j:mainfrom
Conversation
… only to register_functions
jlsandri
force-pushed
the
pr/codegen-dead-else-cleanup
branch
from
04a04db to
7cf34c5
Compare
Author
|
Closing as part of a batch cleanup after #107 landed. The runtime ecosystem refactor in #107 substantially reworked the files this PR touched, and I would like to re-audit the underlying fix against the new code structure before putting it back in front of you. If the fix is still needed after that re-audit, I will re-open as a focused PR rebased onto current main. Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup, no behavioural change.
Changes
elsebranch in the call-emission path ofcode_generator.cpp. The precedingifalways returns or falls through in a way that makes theelseunreachable.ps2_recompiled_functions.hin every generated translation unit. The header is only consumed byregister_functions.cpp, so including it in each generated TU was pure parse-time overhead with no functional effect.Scope
ps2xRecomp/src/lib/code_generator.cpp: +13 / -21Rationale
Tidy-up discovered while working on larger codegen changes in follow-up PRs. Split out as its own PR to keep the review diff minimal and to unblock the follow-ups that touch the same file.