[codex] Link wallet list GitHub accounts

[Squirbie]

Summary

• turn linked GitHub logins on /wallets into account-page links
• keep unlinked wallets showing -
• cover the registered-wallets list and filtered search rendering in the wallet page test

Refs #580.

Before / After

Before: the registered-wallets table showed linked GitHub logins as plain text, so contributors and maintainers had to manually compose /accounts/github:<login> to inspect the account balance, accepted work, and ledger rows.

After: the GitHub column links directly to the matching public account page while preserving the existing wallet search behavior.

Distinctness

This targets the registered-wallets list table. It is distinct from wallet-detail shortcuts (#492), account-detail shortcuts (#483), contributor /me shortcuts (#543), and the activity JSON link (#591), because it starts from /wallets search/list results and improves the linked-wallet-to-account inspection path.

Validation

• .venv/bin/python -m pytest tests/test_wallet_api.py::test_wallet_pages_expose_transfer_and_github_claim_flows -q -> 1 passed
• .venv/bin/python -m pytest tests/test_wallet_api.py -q -> 33 passed
• .venv/bin/python -m pytest -q -> 454 passed
• .venv/bin/python -m ruff check . -> passed
• .venv/bin/python -m ruff format --check . -> 83 files already formatted
• .venv/bin/python -m mypy app -> success
• .venv/bin/python scripts/docs_smoke.py -> docs smoke ok
• git diff --check -> clean

Notes

No wallet material, private keys, cookies, OAuth state, access tokens, signatures, private data, price/liquidity/exchange/off-ramp claims, bridge promises, or fabricated payout claims are included. No screenshot attached because this is a rendered-link behavior change, not a visual layout redesign.

Summary by CodeRabbit

• New Features

  • Wallets table now turns GitHub logins into links to their account pages; wallets without a GitHub login show “-”.

• Tests

  • Updated tests to verify GitHub-linked wallets render account links and that wallets without a GitHub claim (e.g., funded wallets) do not.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c4cd828b-6c03-4813-bd75-81e00c831aa8

📥 Commits

Reviewing files that changed from the base of the PR and between d2ba612 and 29ea600.

📒 Files selected for processing (1)

• tests/test_wallet_api.py

---

📝 Walkthrough

Walkthrough

The PR makes wallet GitHub logins clickable links to /accounts/github:{login} when present, otherwise shows -. Tests assert the account link appears in the main wallets page and filtered search and that a funded wallet row contains no GitHub account link.

Changes

GitHub account linking

Layer / File(s)	Summary
GitHub account link rendering and verification app/templates/wallets.html, tests/test_wallet_api.py	The GitHub column conditionally renders account links to /accounts/github:{login} or a dash. Test assertions verify the linked output in both the wallets page and GitHub-filtered search results, and assert a funded wallet row has no /accounts/github: link.

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly names the changed surface (wallet list GitHub accounts) with concrete action (Link), matching the PR's objective of converting GitHub logins into clickable account links.
Description check	✅ Passed	The description covers summary, evidence of the problem, intended surfaces, validation results across all required checks (ruff, mypy, pytest, docs), and notes on security; all major sections are complete and substantive.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Mergework Public Artifact Hygiene	✅ Passed	PR contains no prohibited claims. Wallets template change only links GitHub accounts; docs correctly describe MRWK as native coin with future snapshots/bridges.
Bounty Pr Focus	✅ Passed	PR changes match stated scope: wallets.html GitHub column links added only to registered-wallets table, test_wallet_api.py validates linked/unlinked wallets in list and search, no scope creep.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 84ab2512-3cdc-47a3-8e5f-173856eede32

📥 Commits

Reviewing files that changed from the base of the PR and between 55d5155 and d2ba612.

📒 Files selected for processing (2)

• app/templates/wallets.html
• tests/test_wallet_api.py

[eliasx45]

Reviewed current head d2ba612c84c257b78c878029d8ab135c8a159ca1.

Verdict: approve with one non-blocking test hardening suggestion.

Evidence:

• Inspected app/templates/wallets.html and tests/test_wallet_api.py.
• The registered-wallets table now links populated wallet.github_login values to /accounts/github:<login> and preserves the - fallback for wallets without a linked GitHub login.
• The regression test checks both the full wallet list and a GitHub-filtered search render the account link for alice-smoke.
• CodeRabbit's extra assertion request for the unlinked-wallet - fallback is a useful follow-up, but the template branch is simple and the existing rendered page still covers an unlinked wallet row in the fixture.
• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests\test_wallet_api.py::test_wallet_pages_expose_transfer_and_github_claim_flows -q -> 1 passed.
• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests\test_wallet_api.py -q -> 33 passed.
• .\.venv\Scripts\python.exe -m ruff check tests\test_wallet_api.py -> passed.
• .\.venv\Scripts\python.exe -m ruff format --check tests\test_wallet_api.py -> 1 file already formatted.
• .\.venv\Scripts\python.exe -m mypy app\wallet_api.py app\accounts.py -> success.
• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe scripts\docs_smoke.py -> docs smoke ok.
• git diff --check origin/main...HEAD -> clean.
• git merge-tree --write-tree origin/main HEAD -> clean merge tree.
• Hosted quality check is green; CodeRabbit status has one trivial/nitpick test suggestion.

I do not see a merge blocker in the scoped wallet-list account-link change.

[eliasx45]

Re-reviewed latest head 29ea600fa65febfbbde49be6e0996ba885045d6a after the test-hardening follow-up.

Verdict: approve.

Evidence:

• Inspected app/templates/wallets.html and tests/test_wallet_api.py.
• The wallet list still links populated GitHub logins to /accounts/github:<login> and preserves the existing - fallback for unlinked wallets.
• The latest commit addresses CodeRabbit's fallback-test request by extracting the Funded smoke wallet table row and asserting it renders the dash fallback without any /accounts/github: link.
• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests\test_wallet_api.py::test_wallet_pages_expose_transfer_and_github_claim_flows -q -> 1 passed.
• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests\test_wallet_api.py -q -> 33 passed.
• .\.venv\Scripts\python.exe -m ruff check tests\test_wallet_api.py -> passed.
• .\.venv\Scripts\python.exe -m ruff format --check tests\test_wallet_api.py -> 1 file already formatted.
• .\.venv\Scripts\python.exe -m mypy app\wallet_api.py app\accounts.py -> success.
• PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe scripts\docs_smoke.py -> docs smoke ok.
• git diff --check origin/main...HEAD -> clean.
• git merge-tree --write-tree origin/main HEAD -> clean merge tree.
• Hosted quality check is green.

I do not see a merge blocker in the scoped wallet-list GitHub account-link change.

[coderabbitai]

Actionable comments posted: 0