Refs #576: Use ASCII punctuation on activity page#588
Refs #576: Use ASCII punctuation on activity page#588fvlaconstancia-lang wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe activity page template updates its search results notice text to use straight quotes instead of curly quotes around the query parameter, and changes the bounty link separator from a middle-dot character to a dash. The test assertions are updated to match the new rendered UI text. ChangesActivity Page UI Text Formatting
Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6ce3bc30-ba3a-4622-ae3c-38a6a87ebebb
📒 Files selected for processing (2)
app/templates/activity.htmltests/test_activity.py
| </form> | ||
| {% if query %} | ||
| <p class="notice">Showing accepted work matching “{{ query }}”.</p> | ||
| <p class="notice">Showing accepted work matching "{{ query }}".</p> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find notice templates that may still use curly quotes
rg -n -C2 'class="notice"' --glob 'app/templates/*.html'Repository: ramimbo/mergework
Length of output: 4724
Standardize quote style in notice text (activity vs wallets)
app/templates/activity.html uses straight quotes: Showing accepted work matching "{{ query }}".
app/templates/wallets.html still uses curly quotes: Showing wallets matching “{{ query_text }}”.
Update wallets.html to use straight quotes if the goal is consistent ASCII punctuation across notice templates.
| <dd> | ||
| {% if row.bounty_url %}<a href="{{ row.bounty_url }}">Bounty #{{ row.bounty_id }}</a>{% endif %} | ||
| {% if row.bounty_url and bounty_issue_url %} · {% endif %} | ||
| {% if row.bounty_url and bounty_issue_url %} - {% endif %} |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find templates that may still use middle-dot separators
rg -n '·' --glob 'app/templates/*.html'Repository: ramimbo/mergework
Length of output: 652
Standardize bounty-link separator punctuation across templates
app/templates/account.htmlstill uses the middle-dot (·) in{% if work.bounty_url and issue_url %} · {% endif %}, whileapp/templates/activity.htmluses-for the same condition.app/templates/bounties.htmlstill contains·separators in the bounty/reward/availability rows (around lines 53–59); switch them to-to matchactivity.html.
eliasx45
left a comment
eliasx45
left a comment
There was a problem hiding this comment.
Reviewed PR #588 at current head 3c738a64d4c459b40db439fad65d576221d24e2b.
No blocker found in the activity-page copy slice. The PR only replaces curly quotes in the search-result notice with ASCII quotes and swaps the middle-dot separator between bounty links for an ASCII hyphen. The activity tests now lock the ASCII-rendered search copy for normal, issue-ref, and no-match filtered states. I also checked that the template no longer contains the curly quote/middle-dot instances this PR targets.
Validation performed:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests\test_activity.py -q-> 3 passed.\.venv\Scripts\python.exe -m ruff check tests\test_activity.py-> passed.\.venv\Scripts\python.exe -m ruff format --check tests\test_activity.py-> 1 file already formattedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe scripts\docs_smoke.py-> docs smoke okPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m mypy app\activity.py app\serializers.py-> successgit diff --check origin/main...HEAD-> clean- current-main merge probe reported already up to date / clean branch state.
Hosted checks/CodeRabbit were still not populated or still processing when I reviewed, so this approval is scoped to the local source and behavior checks above.
|
Follow-up after CodeRabbit's two comments: I rechecked them against the PR scope and #576. Both are broader consistency suggestions outside this activity-page slice: Those would be reasonable follow-up cleanup targets if the project wants a global ASCII-punctuation pass, but I do not see them invalidating this PR. The current diff only changes the activity page notice/separator and updates the activity-page tests accordingly; CodeRabbit/check status is now green/skipped, and my approval for the focused activity-page change stands. |
2 participants
Refs #576
Summary:
Why:
Some plain HTTP clients and test output can show UTF-8 punctuation as mojibake. Keeping this small activity-page copy ASCII avoids the rendering glitch without changing behavior.
Validation:
Summary by CodeRabbit
Release Notes