Refs #426: Document health response shape#553
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated API documentation to include a new ChangesHealth Endpoint Documentation
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
bitdamii
left a comment
There was a problem hiding this comment.
Reviewed PR #553 at current head 49ae4b06220044dfc47126a70eff7de375e55e3a as non-author bitdamii.
Evidence: inspected docs/api-examples.md, tests/test_docs_public_urls.py, and the existing /health implementation in app/main.py and app/status.py; confirmed the docs now separate lightweight /health monitoring from full /api/v1/status, list the exact public response fields (ok, service, ticker, ledger_height), and add a regression so the endpoint is not documented without its shape. The sample matches health_status() and does not add payout, price, liquidity, off-ramp, wallet-secret, or private-data claims.
Validation: uv run --extra dev python -m pytest tests/test_docs_public_urls.py::test_api_examples_document_health_response_shape tests/test_status.py::test_health_status_reports_current_ledger_height tests/test_api_mcp.py::test_health_status_and_bounty_api -q -> 3 passed; uv run --extra dev python -m pytest tests/test_docs_public_urls.py tests/test_status.py tests/test_api_mcp.py::test_health_status_and_bounty_api -q -> 27 passed; uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok; uv run --extra dev ruff check docs/api-examples.md tests/test_docs_public_urls.py passed; uv run --extra dev ruff format --check tests/test_docs_public_urls.py passed; uv run --extra dev python -m mypy app/status.py app/main.py passed; git diff --check origin/main...HEAD clean. GitHub Quality/readiness/docs/image checks and CodeRabbit are successful with no actionable comments.
No blocker found in this reviewed slice.
|
Reviewed PR #553 at Evidence checked:
Validation:
Assessment: no blocker found in this docs/test slice. The documented shape matches the implementation and stays within public liveness/status fields, without adding price, liquidity, exchange, bridge, off-ramp, private-key, or fabricated payout claims. |
eliasx45
left a comment
There was a problem hiding this comment.
Reviewed current head 49ae4b06220044dfc47126a70eff7de375e55e3a for the /health documentation change.
No blocker found. The PR is narrow: it documents /health as the lightweight liveness/ledger-height endpoint, keeps /api/v1/status positioned for heavier counters and treasury data, and adds a docs regression so the health endpoint is not listed without its response fields. The documented keys match app.status.health_status() and the registered GET /health route.
Evidence checked:
- inspected
docs/api-examples.md,tests/test_docs_public_urls.py,app/main.py,app/status.py,tests/test_status.py, andtests/test_api_mcp.py; - confirmed
/healthreturnshealth_status(session)fromapp/main.py; - confirmed
health_status()exposesok,service,ticker, andledger_heightonly; - confirmed the docs describe
/healthas a small polling endpoint and keep/api/v1/statusfor broader counters; - public probes returned HTTP 200 from both
https://api.mrwk.ltclab.site/healthandhttps://mrwk.ltclab.site/health, with the documented key shape and liveledger_height831.
Validation performed:
.\.venv\Scripts\python.exe -m pytest tests\test_docs_public_urls.py::test_api_examples_document_health_response_shape tests\test_status.py::test_health_status_reports_current_ledger_height tests\test_api_mcp.py::test_health_status_and_bounty_api -q-> 3 passed..\.venv\Scripts\python.exe scripts\docs_smoke.py-> docs smoke ok..\.venv\Scripts\python.exe -m pytest tests\test_docs_public_urls.py tests\test_status.py tests\test_api_mcp.py::test_health_status_and_bounty_api -q-> 27 passed..\.venv\Scripts\python.exe -m ruff check tests\test_docs_public_urls.py app\status.py app\main.py-> passed..\.venv\Scripts\python.exe -m ruff format --check tests\test_docs_public_urls.py app\status.py app\main.py-> 3 files already formatted..\.venv\Scripts\python.exe -m mypy app\status.py app\main.py-> success..\.venv\Scripts\python.exe -m pytest -q-> 415 passed.git diff --check origin/main...HEAD-> clean.- GitHub PR checks are passing, including CodeRabbit and the quality/readiness/docs/image workflow.
This looks mergeable from my reviewed slice.
|
Bounty #426 is now filled and closed, so this PR is not currently payable under that bounty. Leaving |
barnacleagent-svg
left a comment
There was a problem hiding this comment.
Verdict: APPROVED
Scope: Documents /health response shape in docs/api-examples.md. Adds curl example and JSON response with ok, service, ticker, ledger_height fields.
Checklist:
- Diff: +30/-2 across 2 files
- Documentation-only, no logic change
- Tests verify new content
Conclusion: Clean documentation addition. Ready to merge.
wangedmund77-cmyk
left a comment
There was a problem hiding this comment.
Reviewed current head 49ae4b06220044dfc47126a70eff7de375e55e3a for bounty #578.
Evidence checked:
- Inspected
docs/api-examples.mdandtests/test_docs_public_urls.py. git diff --check origin/main...origin/pr/553returned clean.- Ran
uv run pytest tests/test_docs_public_urls.py -qon the PR head: 24 passed. - GitHub mergeability is clean/MERGEABLE.
No blocker found. The docs now show the public /health response fields without implying private/admin data, and the docs URL smoke coverage was updated with the new live API reference.
Refs #426
Summary
/healthindocs/api-examples.mdas the lightweight liveness and ledger-height endpointok,service,ticker, andledger_heightEvidence
app/main.pyregistersGET /healthand returnshealth_status(session).app/status.pyreturns onlyok,service,ticker, andledger_heightfor the health endpoint.https://api.mrwk.ltclab.site/health->{"ledger_height":792,"ok":true,"service":"mergework","ticker":"MRWK"}https://mrwk.ltclab.site/health-> same shapeValidation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ./.venv/bin/python scripts/docs_smoke.py->docs smoke okPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ./.venv/bin/python -m pytest tests/test_docs_public_urls.py::test_api_examples_document_health_response_shape tests/test_docs_public_urls.py::test_api_examples_document_internal_bounty_ids -q->2 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 ./.venv/bin/python -m pytest tests/test_docs_public_urls.py -q->24 passed./.venv/bin/python -m ruff check tests/test_docs_public_urls.py-> passed./.venv/bin/python -m ruff format --check tests/test_docs_public_urls.py-> already formattedgit diff --check origin/main...HEAD-> cleanNo private data, cookies, tokens, wallet material, signatures, price claims, liquidity/exchange/off-ramp claims, bridge promises, or fabricated payout claims are included.
Summary by CodeRabbit
Documentation
/healthAPI endpoint documentation including curl command example and sample JSON response with system liveness and ledger height information.Tests