Conversation
kakra
force-pushed
the
feat/effects-enable-control
branch
2 times, most recently
from
August 26, 2026 06:33
d2844fb to
bba68c9
Compare
Replace the function-local effects toggle with device-scoped shared state. Let the existing hotkey and an Effects-tab checkbox read and update the same value.
kakra
force-pushed
the
feat/effects-enable-control
branch
from
August 26, 2026 20:20
bba68c9 to
1529171
Compare
Contributor
Author
|
Updated the top post. The PR deliberately remains a draft pending a decision on state ownership. |
Owner
|
Hey, since this PR was quite out of date and needed some changes anyway, I just went ahead and put it together quickly in #136 using the internal ConfigStore for global state tracking. It's not thread-safe, but nothing really is at this stage. Once the broader ownership issues are resolved I'll look at adding locking to ConfigStore, to properly support multiple swapchains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the current effects state in the Effects tab and allow it to be changed directly from the GUI.
Effects enabledcheckbox next toReload Active EffectsToggleEffectshotkeyMotivation
The hotkey is useful for visual A/B comparisons, but after switching several times it can be difficult to remember whether the effect chain is currently enabled.
The checkbox makes the active state immediately visible while preserving the existing hotkey workflow.
Implementation
The current implementation stores the state in a device-scoped shared atomic value. This lets the rendering path, hotkey, and GUI observe and modify the same state without introducing a separate UI-only copy.
You previously mentioned that you may prefer different ownership for this state. I have kept the current implementation as a concrete review basis and am happy to adapt it to your preferred design.
Scope
This branch is now based directly on the current
mainand contains a single commit:1529171 feat(gui): add effects enable controlIt no longer depends on the superseded live-log PR or any other local feature branch.
Testing
meson compile -C buildmeson test -C build --print-errorlogsgit diff --checkA final ETS2 smoke test of checkbox/hotkey synchronization will be done before removing the draft status.