feat(query): add isnull operator for NULL checks#528
feat(query): add isnull operator for NULL checks#528joshdimanteto merged 3 commits intoremove-older-python-versions-#517from
Conversation
1cf6592 to
b11f9f6
Compare
31ca501 to
f21d3b2
Compare
patrick-austin
left a comment
There was a problem hiding this comment.
Code looks OK to me but haven't had a chance to run it yet, will try and do that when I can before approving.
I note that this is not the solution that @louise-davies suggested - are you happy enough with this as is and dealing with a general solution for the discrepancy between boolean equality and is-ness (not sure what the word for that is - identity?) when/if it comes to it?
@patrick-austin Apparently JPQL doesn't support the |
patrick-austin
left a comment
There was a problem hiding this comment.
Tried it on my dev ICAT and gave the expected number of results for "isnull": true and "isnull": false.
060d71a
into
remove-older-python-versions-#517
This PR will close #527
Description
see #527
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
#527