remove database backend #489#507
Conversation
5e5d6c4 to
743b34b
Compare
86a347f to
c3a28c4
Compare
c3a28c4 to
2939010
Compare
e1afd0a to
34d2603
Compare
- remove downgrade of setuptools
Added `# noqa: B907` in several places where manual quoting is required for valid SQL query syntax. Using `!r` would change the format and break query parsing, so explicit quotes are necessary. This ensures tests and API calls remain correct while satisfying linting requirements.
94aad25 to
e280471
Compare
9ac04a6 to
84b9f59
Compare
| @@ -45,11 +42,10 @@ def flask_test_app(): | |||
| def flask_test_app_db(): | |||
There was a problem hiding this comment.
This name should change. I have changed in #524 where i had to refactored the tests
a68b552 to
9fae76f
Compare
VKTB
left a comment
There was a problem hiding this comment.
I think the changes look fine, I tried my best. I have not tested it locally as I don't have a working stack to point it it to so I just trust that it works as expected. Might be worth asking someone else to have a look too. Approving.
patrick-austin
left a comment
There was a problem hiding this comment.
Functionally I think it's OK (I can run the API and get results back).
There's a few whitespace changes I would make (as a result of strings being moved onto one line) and one or two possible code changes.
- remove unnecessary argument "validate_assignment = True" in config - format strings better in test_query for title - update README
- remove installation of java this should installed by the ansible script
patrick-austin
left a comment
There was a problem hiding this comment.
As discussed over Teams, there are some instances where the models do not strictly represent the types/fields required by the API (for example required fields when POSTing or id when PATCHing).
However, given that further changes are in progress with the FastAPI refactor and the primary use case for the API is DataGateway's read operations, I'm happy that the use of Optional lets things work for now, and it doesn't matter so much that someone referring to the Swagger wouldn't know id is required for PATCH (as who's looking at the Swagger in the first place?)
5a831a1 to
8b29a8b
Compare
This PR will close #489
Description
Remove the database backend functionality from the DataGateway API. It includes significant changes such as deleting database-related files and functionality, updating tests to remove database dependencies, and modifying the configuration to align with the changes.
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #489
notes
The icat models still use SQLAlchemy, this is going to be update in the pydantic V2 upgrade to use pydantic