fix: avoid injecting a layout wrapper - #2697
Conversation
|
|
Someone is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d09adb991
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <ModalProvider> | ||
| {theme ? ( | ||
| <div {...createThemeRootProps(id)}> | ||
| <> |
There was a problem hiding this comment.
Keep a data-rk ancestor for inline components
With the default non-null theme, replacing this element with a fragment removes the only data-rk ancestor from ordinary provider children. The build prefixes all Vanilla Extract selectors with [data-rk], and components such as ConnectButton do not call useThemeRootProps, so a normally rendered connect button no longer matches its CSS rules or inherits the theme variables; only portal dialogs explicitly add the attribute themselves. Retain a non-layout theme root or attach the theme-root props to every inline RainbowKit component root.
AGENTS.md reference: AGENTS.md:L75-L79
Useful? React with 馃憤聽/ 馃憥.
| <ModalProvider> | ||
| {theme ? ( | ||
| <div {...createThemeRootProps(id)}> | ||
| <> |
There was a problem hiding this comment.
Add a changeset for the provider behavior change
This changes the default provider's rendered DOM and is explicitly a user-facing bug fix, but the commit contains no .changeset entry for @rainbow-me/rainbowkit. Without one, the release queue will not version or document this package change, so it can be omitted from the next release unless an unrelated changeset happens to include the package.
AGENTS.md reference: AGENTS.md:L99-L104
Useful? React with 馃憤聽/ 馃憥.
Summary
Fixes #2164.
Remove the extra
divinjected byRainbowKitProviderwhen a theme is active. The provider now uses a fragment, so application children keep their original DOM structure and layout behavior. Theme CSS injection remains unchanged.Validation
git diff --checkpassed.