[API] Ignore If-Modified-Since when If-None-Match is present#330
Open
RedZapdos123 wants to merge 1 commit into
Open
[API] Ignore If-Modified-Since when If-None-Match is present#330RedZapdos123 wants to merge 1 commit into
RedZapdos123 wants to merge 1 commit into
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #329 reported that Rage still evaluated
If-Modified-SincewhenIf-None-Matchwas present, so an olderIf-Modified-Sincecould force a200 OKeven whenIf-None-Matchalready matched.This PR updates
Rage::Request#fresh?to giveIf-None-Matchprecedence when it is present and only fall back toIf-Modified-Sincewhen noIf-None-Matchheader is sent.It also adds regression tests for the matching
If-None-Match+ staleIf-Modified-Sincecase and for the path where the response only sets an ETag.Closes #329.
Checklist:
bundle exec rubocop --except Layout/EndOfLine lib/rage/request.rb spec/controller/api/conditional_get_spec.rb.bundle exec rspec spec/controller/api/conditional_get_spec.rb.bundle exec rspec spec/controller/api.Before the fix:
After the fix: