[API] Use weak comparison for If-None-Match validation#325
Open
RedZapdos123 wants to merge 2 commits into
Open
[API] Use weak comparison for If-None-Match validation#325RedZapdos123 wants to merge 2 commits into
RedZapdos123 wants to merge 2 commits into
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
rsamoilov
reviewed
Jun 14, 2026
rsamoilov
left a comment
rsamoilov
left a comment
Member
There was a problem hiding this comment.
This looks great! Left just one minor suggestion.
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #324 reported that
If-None-Matchvalidation used exact string comparison, so a strong request ETag like"..."did not match Rage's weak response ETagW/"...".This PR updates
Rage::Request#etag_matches?to use weak comparison forIf-None-Matchvalidation, while keeping wildcard handling unchanged.It also updates the conditional GET regression spec to cover the strong-request / weak-response match and adds a changelog entry.
Closes #324.
Checklist:
bundle exec rubocop --except Layout/EndOfLine lib/rage/request.rb spec/controller/api/conditional_get_spec.rb.bundle exec rspec spec/controller/api/conditional_get_spec.rb.bundle exec rspec spec/controller/api.Before the fix:
After the fix: