-
Notifications
You must be signed in to change notification settings - Fork 33
FENCE-2649: Add vendored xcframework #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
FENCE-2649: Add vendored xcframework #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request migrates the iOS SDK dependency from CocoaPods trunk (which is deprecated) to vendored XCFrameworks bundled directly in the package. The change addresses the deprecation of CocoaPods trunk by including RadarSDK.xcframework and RadarSDKMotion.xcframework directly in the repository.
Changes:
- Bundles RadarSDK version 3.25.2 xcframeworks directly in the
ios/directory - Replaces external CocoaPods dependency with vendored frameworks in podspec files
- Replaces
RadarSettingsAPI (no longer available) with local static storage for publishable key and hardcoded default host value - Updates Expo plugin to reference the new
RadarMotionpodspec with local path
Reviewed changes
Copilot reviewed 19 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/download-xcframeworks.sh |
New script to download xcframeworks from GitHub releases |
Radar.podspec |
Updated to use vendored RadarSDK.xcframework instead of external CocoaPods dependency |
RadarMotion.podspec |
New podspec for optional RadarSDKMotion support with vendored framework |
ios/RadarMotionStub.swift |
Stub file for RadarMotion podspec |
ios/RNRadar.mm |
Replaces RadarSettings API with static variable for publishableKey storage |
ios/RNRadar.h |
Removes import of RadarSettings header |
plugin/src/withRadarIOS.ts |
Updates Expo plugin to add RadarMotion pod with local path reference |
ios/RadarSDK.xcframework/* |
Vendored RadarSDK framework version 3.25.2 |
ios/RadarSDKMotion.xcframework/* |
Vendored RadarSDKMotion framework version 3.25.2 |
.circleci/config.yml |
Updates iOS build resource class to m4pro.large |
.gitignore |
Adds comments indicating vendored frameworks should not be ignored |
example/app.json |
Example app configuration updates (disables new arch, adds team ID) |
example/App.tsx |
Updates to complete test API key for example |
example/package-lock.json |
Version bump to 3.24.0 |
Files not reviewed (1)
- example/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works.
rm the key from example app and should be good to go.
we can do a beta release and make sure this works as a package with waypoint or a simple app, test with both old + new arch.
Migrate iOS SDK dependency from CocoaPods trunk to a vendored XCFramework. CocoaPods trunk is deprecated and no longer accepting new pod publications. This change bundles the RadarSDK XCFramework directly in the package, eliminating the external dependency.
RadarSDK.xcframeworkandRadarSDKMotion.xcframeworkdirectly inios/directorys.dependency "RadarSDK"withs.vendored_frameworksRadarMotion.podspecas a separate podspec for optionalRadarSDKMotionsupportwithRadarIOS.tsto reference newRadarMotionpodRadarSettingswith local storage forpublishableKeyand default value forhost