Open
Conversation
aishwary08
requested changes
Feb 17, 2020
Collaborator
aishwary08
left a comment
There was a problem hiding this comment.
- Use destructuring and default values.
- Avoid using inline styles and id selector styles
- Best to use class styles (Its easier for external consumer to override them)
- Add comments in you code base
- Can you come-up with a centralized implementation of mSTP and mDTP? Because it looks redundant.
- Create separate CSS file for each component.
- Prefer using const over let.
- Take care of the code indentation
- Avoid margins if you can, Prefer using Padding.
- Remove Commented code before pushing for review. Also, its a good practice to review the code by yourself before pushing for final review. One of the way to do it is, by comparing your branch with master/dev (whichever is your main branch).
2. Changed onClick prop 3. Removed mapStateToProps function as it was not required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.