Conversation
e-kotov
marked this pull request as draft
September 17, 2026 14:11
Contributor
Author
|
@tim-salabim this is in relation to the batching question, but ignore for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow.tableFromIPC(response)waits for the complete HTTP response before exposing any record batches, so smaller server-side batches currently create more layers without showing pixels earlier.This change reads Arrow IPC with
RecordBatchReader.from(response.body)and appends one stable Deck.gl layer as each batch arrives. The shared loader keeps the currentparse2ArrowTable()path for GeoParquet and FlatGeobuf, including the new upstream FlatGeobuf support.Verification
node tests-js/progressive-arrow-batches.test.mjsinst/htmlwidgets/R CMD build .R CMD check --no-manual deckglgeoarrow_0.1.0.9001.tar.gzThe JavaScript regression test verifies that the first layer is installed before the second Arrow batch is read and that the non-Arrow parser path remains available. The package check completes with the warnings already present on current
mainfor the removed point-cloud methods and the developmentgeoarrowWidgetFlatGeobuf helper.