Add a check example using MacOSX11.3 SDK#1077
Open
remlapmot wants to merge 1 commit into
Open
Conversation
This SDK is installed on CRAN's r-release-macos-x86_64, r-oldrel-macos-arm64, r-oldrel-macos-x86_64 machines, where missing explicit C++ standard library includes cause build failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2-branch #1077 +/- ##
==========================================
Coverage 83.33% 83.33%
==========================================
Files 3 3
Lines 12 12
==========================================
Hits 10 10
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks, it would be great to have this in some form! I think it is not ideal to have a separate workflow for this, but it could be a separate action, or it could be an option for One issue is that we don't want to download the tools from an untrusted repository. Ideally we'd download them from the official Apple URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently took on maintaining an R package with some C++ code. I did some tinkering, all my checks using the existing r-lib/actions checked passed (and checks with rhub) but after being accepted onto CRAN I obtained installation errors on the r-release-macos-x86_64, r-oldrel-macos-arm64, and r-oldrel-macos-x86_64 CRAN machines.
It turns out those CRAN machines have this 11.3 SDK installed which has very strict rules about specifying
#includes.In this I have specified the macos-15/macos-15-intel runners because there is no macos-11 runner. Those CRAN machines don't run on macos 15 (I guess they have macOS 11) but that doesn't seem to matter - it's just the use of this older SDK. This workflow recreates the errors I received from those 3 CRAN machines for my slightly slack code.
Even if you don't take this, I thought this might be helpful in the history of the repo to others.